Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(display): Update to support multiple displays #391

Merged
merged 3 commits into from
Mar 3, 2025
Merged

feat(display): Update to support multiple displays #391

merged 3 commits into from
Mar 3, 2025

Conversation

finger563
Copy link
Contributor

Description

  • Update espp::Display to store the flush and rotate functions and to pass this as the context for the lvgl display and event callback

Motivation and Context

This allows any arbitrary function (including bound class member functions) to be passed for the flush callback and rotate callbacks, instead of requiring that they match the signatures and linkage of the lvgl lower-layer functions. This will enable a follow-up PR which allows the display drivers to no longer be static classes, further enabling multiple displays to be used in a single project.

How has this been tested?

Build and run esp-box/example, t-dongle-s3/example to ensure the existing code still works.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563
feat(display): Update to support multiple displays
0ccb99d 
* Update `espp::Display` to store the `flush` and `rotate` functions and to pass `this` as the context for the lvgl `display` and `event` callback

This allows any arbitrary function (including bound class member functions) to be passed for the flush callback and rotate callbacks, instead of requiring that they match the signatures and linkage of the lvgl lower-layer functions. This will enable a follow-up PR which allows the display drivers to no longer be static classes, further enabling multiple displays to be used in a single project.

Build and run `esp-box/example`, `t-dongle-s3/example` to ensure the existing code still works.
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚡ Static analysis result ⚡

🔴 cppcheck found 108 issues! Click here to see details.

espp/components/wrover-kit/src/wrover-kit.cpp

Lines 21 to 26 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = WroverKit::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 21 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 64 - note: You might need to cast the function pointer here
!Line: 21 - note: Parameter 't' can be declared as pointer to const

espp/components/wrover-kit/src/wrover-kit.cpp

Lines 31 to 36 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 31 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 65 - note: You might need to cast the function pointer here
!Line: 31 - note: Parameter 't' can be declared as pointer to const

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/ftp/include/ftp_client.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/cli/include/line_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/cli/include/cli.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/cli/include/line_input.hpp

Lines 87 to 92 in 234bf21

History get_history() const { return input_history_; }
/**
* @brief Replace any existing input history with \p history.
* @note If \p history is longer than the current history_size, it will be
* truncated (oldest removed) to have size equal to history_size. 

!Line: 87 - performance: Function 'get_history()' should return member 'input_history_' by const reference. [returnByReference]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/file_system/src/file_system.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/button/example/main/button_example.cpp

Lines 34 to 39 in 234bf21

std::string button_component_name = "button";
// create a button
espp::Button button({
.name = "Button 12",
.interrupt_config = 

!Line: 34 - style: Variable 'button_component_name' is assigned a value that is never used. [unreadVariable]

espp/components/ft5x06/example/main/ft5x06_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting ft5x06 example\n");
//! [ft5x06 example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

espp/components/max1704x/example/main/max1704x_example.cpp

Lines 28 to 33 in 234bf21

std::error_code ec;
// and finally, make the task to periodically poll the max1704x and print
// the state. NOTE: the Max1704x does not internally manage its own state
// update, so whatever rate we use here is the rate at which the state will
// update. 

!Line: 28 - style: Unused variable: ec [unusedVariable]

espp/components/ads7138/example/main/ads7138_example.cpp

Lines 128 to 133 in 234bf21

.callback = [&ads](auto &m, auto &cv) -> bool {
static uint32_t io_num;
// block until we get a message from the interrupt handler
if (xQueueReceive(gpio_evt_queue, &io_num, portMAX_DELAY)) {
// see if it's the mute button
if (io_num == (int)ALERT_PIN) { 

!Line: 128 - style: Parameter 'm' can be declared as reference to const [constParameterReference]

espp/components/ads7138/example/main/ads7138_example.cpp

Lines 128 to 133 in 234bf21

.callback = [&ads](auto &m, auto &cv) -> bool {
static uint32_t io_num;
// block until we get a message from the interrupt handler
if (xQueueReceive(gpio_evt_queue, &io_num, portMAX_DELAY)) {
// see if it's the mute button
if (io_num == (int)ALERT_PIN) { 

!Line: 128 - style: Parameter 'cv' can be declared as reference to const [constParameterReference]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/binary-log/example/main/binary_log_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/chsc6x/example/main/chsc6x_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting chsc6x example\n");
//! [chsc6x example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

espp/components/interrupt/include/interrupt.hpp

Lines 410 to 415 in 234bf21

bool task_callback(std::mutex &m, std::condition_variable &cv, bool &task_notified) {
EventData event_data;
// record the min number of free spaces in the queue
size_t free_spaces = uxQueueSpacesAvailable(queue_);
if (free_spaces < min_queue_size_) {
min_queue_size_ = free_spaces; 

!Line: 410 - style: Parameter 'm' can be declared as reference to const. However it seems that 'task_callback' is a callback function, if 'm' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 176 - note: You might need to cast the function pointer here
!Line: 410 - note: Parameter 'm' can be declared as reference to const

espp/components/interrupt/include/interrupt.hpp

Lines 410 to 415 in 234bf21

bool task_callback(std::mutex &m, std::condition_variable &cv, bool &task_notified) {
EventData event_data;
// record the min number of free spaces in the queue
size_t free_spaces = uxQueueSpacesAvailable(queue_);
if (free_spaces < min_queue_size_) {
min_queue_size_ = free_spaces; 

!Line: 410 - style: Parameter 'cv' can be declared as reference to const. However it seems that 'task_callback' is a callback function, if 'cv' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 176 - note: You might need to cast the function pointer here
!Line: 410 - note: Parameter 'cv' can be declared as reference to const

espp/components/interrupt/include/interrupt.hpp

Lines 410 to 415 in 234bf21

bool task_callback(std::mutex &m, std::condition_variable &cv, bool &task_notified) {
EventData event_data;
// record the min number of free spaces in the queue
size_t free_spaces = uxQueueSpacesAvailable(queue_);
if (free_spaces < min_queue_size_) {
min_queue_size_ = free_spaces; 

!Line: 410 - style: Parameter 'task_notified' can be declared as reference to const. However it seems that 'task_callback' is a callback function, if 'task_notified' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 176 - note: You might need to cast the function pointer here
!Line: 410 - note: Parameter 'task_notified' can be declared as reference to const

espp/components/cst816/example/main/cst816_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting cst816 example\n");
//! [cst816 example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/ble_gatt_server/include/ble_gatt_server_menu.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/ble_gatt_server/example/main/ble_gatt_server_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/gfps_service/src/nearby_battery.cpp

Lines 6 to 11 in 234bf21

nearby_platform_status nearby_platform_GetBatteryInfo(nearby_platform_BatteryInfo *battery_info) {
// TODO: Implement
return kNearbyStatusOK;
}
// Initializes battery module 

!Line: 6 - style: Parameter 'battery_info' can be declared as pointer to const [constParameterPointer]

espp/components/gfps_service/src/nearby_battery.cpp

Lines 15 to 18 in 234bf21

nearby_platform_BatteryInit(nearby_platform_BatteryInterface *battery_interface) {
// TODO: Implement
return kNearbyStatusOK;
} 

!Line: 15 - style: Parameter 'battery_interface' can be declared as pointer to const [constParameterPointer]

espp/components/gfps_service/src/nearby_audio.cpp

Lines 66 to 71 in 234bf21

void nearby_platform_GetConnectionBitmap(uint8_t *bitmap, size_t *length) {
// TODO: implement
}
// Returns true is SASS state in On
bool nearby_platform_IsSassOn() { 

!Line: 66 - style: Parameter 'bitmap' can be declared as pointer to const [constParameterPointer]

espp/components/gfps_service/src/nearby_audio.cpp

Lines 66 to 71 in 234bf21

void nearby_platform_GetConnectionBitmap(uint8_t *bitmap, size_t *length) {
// TODO: implement
}
// Returns true is SASS state in On
bool nearby_platform_IsSassOn() { 

!Line: 66 - style: Parameter 'length' can be declared as pointer to const [constParameterPointer]

espp/components/gfps_service/example/main/gfps_service_example.cpp

Lines 24 to 29 in 234bf21

.connect_callback = [&](NimBLEConnInfo &conn_info) { logger.info("Device connected"); },
.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
.get_passkey_callback = [&]() { return NimBLEDevice::getSecurityPasskey(); }, 

!Line: 24 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

espp/components/gfps_service/example/main/gfps_service_example.cpp

Lines 25 to 30 in 234bf21

.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
.get_passkey_callback = [&]() { return NimBLEDevice::getSecurityPasskey(); },
.confirm_passkey_callback = 

!Line: 25 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/event_manager/src/event_manager.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/ble_gatt_server/example/main/ble_gatt_server_example.cpp

Lines 27 to 32 in 234bf21

.connect_callback = [&](NimBLEConnInfo &conn_info) { logger.info("Device connected"); },
.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
// NOTE: this is optional, if you don't provide this callback, it will 

!Line: 27 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

espp/components/ble_gatt_server/example/main/ble_gatt_server_example.cpp

Lines 28 to 33 in 234bf21

.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
// NOTE: this is optional, if you don't provide this callback, it will
// perform the exactly function as below: 

!Line: 28 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/hid_service/example/main/hid_service_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/hid_service/example/main/hid_service_example.cpp

Lines 72 to 77 in 234bf21

.connect_callback = [&](NimBLEConnInfo &conn_info) { logger.info("Device connected"); },
.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
// NOTE: this is optional, if you don't provide this callback, it will 

!Line: 72 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

espp/components/hid_service/example/main/hid_service_example.cpp

Lines 73 to 78 in 234bf21

.disconnect_callback = [&](auto &conn_info,
auto reason) { logger.info("Device disconnected: {}", reason); },
.authentication_complete_callback =
[&](const NimBLEConnInfo &conn_info) { logger.info("Device authenticated"); },
// NOTE: this is optional, if you don't provide this callback, it will
// perform the exactly function as below: 

!Line: 73 - style: Parameter 'conn_info' can be declared as reference to const [constParameterReference]

espp/components/hid-rp/include/hid-rp-switch-pro.hpp

Lines 195 to 200 in 234bf21

counter = prev_counter;
// set the joysticks to 0 since their config may not put them at 0
set_left_joystick(0, 0);
set_right_joystick(0, 0);
} 

!Line: 195 - style: Variable 'counter' is assigned an expression that holds the same value. [redundantAssignment]

!Line: 191 - note: prev_counter is assigned 'counter' here.
!Line: 195 - note: Variable 'counter' is assigned an expression that holds the same value.

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/color/src/color.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/rmt/example/main/rmt_example.cpp

Lines 54 to 59 in 234bf21

rmt_encode_state_t *ret_state) -> size_t {
// divide by 2 since we have both duration0 and duration1 in the reset code
static uint16_t reset_ticks =
WS2812_FREQ_HZ / MICROS_PER_SEC * 50 / 2; // reset code duration defaults to 50us
static rmt_symbol_word_t led_reset_code = (rmt_symbol_word_t){
.duration0 = reset_ticks, 

!Line: 54 - style: Parameter 'ret_state' can be declared as pointer to const [constParameterPointer]

espp/components/tt21100/example/main/tt21100_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting tt2100 example\n");
//! [tt21100 example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

espp/components/t-dongle-s3/src/t-dongle-s3.cpp

Lines 128 to 133 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = TDongleS3::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 128 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 170 - note: You might need to cast the function pointer here
!Line: 128 - note: Parameter 't' can be declared as pointer to const

espp/components/t-dongle-s3/src/t-dongle-s3.cpp

Lines 138 to 143 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_disp_get_default();
lv_display_flush_ready(disp); 

!Line: 138 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 171 - note: You might need to cast the function pointer here
!Line: 138 - note: Parameter 't' can be declared as pointer to const

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/input_drivers/include/touchpad_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/input_drivers/include/keypad_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/esp-box/example/main/esp_box_example.cpp

Lines 186 to 191 in 234bf21

extern const char wav_start[] asm("_binary_click_wav_start");
extern const char wav_end[] asm("_binary_click_wav_end");
// -1 due to the size being 1 byte too large, I think because end is the byte
// immediately after the last byte in the memory but I'm not sure - cmm 2022-08-20
// 

!Line: 186 - error: syntax error [syntaxError]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/gt911/include/gt911.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/esp-box/src/video.cpp

Lines 18 to 23 in 234bf21

static void lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = EspBox::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 18 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 60 - note: You might need to cast the function pointer here
!Line: 18 - note: Parameter 't' can be declared as pointer to const

espp/components/esp-box/src/video.cpp

Lines 28 to 33 in 234bf21

static void lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 28 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 61 - note: You might need to cast the function pointer here
!Line: 28 - note: Parameter 't' can be declared as pointer to const

espp/components/gt911/example/main/gt911_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting gt911 example\n");
//! [gt911 example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/nvs/example/main/nvs_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/matouch-rotary-display/example/main/matouch_rotary_display_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/bm8563/example/main/bm8563_example.cpp

Lines 13 to 18 in 234bf21

std::atomic<bool> quit_test = false;
fmt::print("Starting tt2100 example\n");
//! [bm8563 example]
// make the I2C that we'll use to communicate
espp::I2c i2c({
.port = I2C_NUM_0, 

!Line: 13 - style: Variable 'quit_test' is assigned a value that is never used. [unreadVariable]

espp/components/matouch-rotary-display/src/matouch-rotary-display.cpp

Lines 215 to 220 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = MatouchRotaryDisplay::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 215 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 257 - note: You might need to cast the function pointer here
!Line: 215 - note: Parameter 't' can be declared as pointer to const

espp/components/matouch-rotary-display/src/matouch-rotary-display.cpp

Lines 225 to 230 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 225 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 258 - note: You might need to cast the function pointer here
!Line: 225 - note: Parameter 't' can be declared as pointer to const

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/rtsp/include/jpeg_header.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/rtsp/include/rtsp_client.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/rtsp/include/rtsp_server.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/rtsp/include/jpeg_frame.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/monitor/example/main/monitor_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 656 to 661 in 234bf21

State_2::ChildState COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ;
DeepHistoryState COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ;
State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ;
State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ;
State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 

!Line: 656 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 240 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 656 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 657 to 662 in 234bf21

DeepHistoryState COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ;
State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ;
State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ;
State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 

!Line: 657 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 241 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 657 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 658 to 663 in 234bf21

State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ;
State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ;
State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ;
State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
State_2 COMPLEX_OBJ__STATE_2_OBJ; 

!Line: 658 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 242 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 658 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 659 to 664 in 234bf21

State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ;
State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ;
State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
State_2 COMPLEX_OBJ__STATE_2_OBJ;
State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ; 

!Line: 659 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 243 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.
!Line: 659 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 660 to 665 in 234bf21

State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ;
State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
State_2 COMPLEX_OBJ__STATE_2_OBJ;
State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 

!Line: 660 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 245 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.
!Line: 660 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 661 to 666 in 234bf21

State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
State_2 COMPLEX_OBJ__STATE_2_OBJ;
State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 

!Line: 661 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 247 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 661 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 662 to 667 in 234bf21

ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
State_2 COMPLEX_OBJ__STATE_2_OBJ;
State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ; 

!Line: 662 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 248 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 662 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 664 to 669 in 234bf21

State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ;
ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ;
State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ;
State3 COMPLEX_OBJ__STATE3_OBJ; 

!Line: 664 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 250 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 664 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 665 to 670 in 234bf21

ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;
DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ;
State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ;
State3 COMPLEX_OBJ__STATE3_OBJ;
// END state object 

!Line: 665 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 251 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 665 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 666 to 671 in 234bf21

DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;
State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ;
State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ;
State3 COMPLEX_OBJ__STATE3_OBJ;
// END state object
End_State COMPLEX_OBJ__END_STATE_OBJ; 

!Line: 666 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 252 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 666 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 667 to 672 in 234bf21

State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ;
State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ;
State3 COMPLEX_OBJ__STATE3_OBJ;
// END state object
End_State COMPLEX_OBJ__END_STATE_OBJ;
// Keep a _root for easier templating, it will point to us 

!Line: 667 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 253 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 667 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 668 to 673 in 234bf21

State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ;
State3 COMPLEX_OBJ__STATE3_OBJ;
// END state object
End_State COMPLEX_OBJ__END_STATE_OBJ;
// Keep a _root for easier templating, it will point to us
Root *_root; 

!Line: 668 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 254 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 668 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 60 to 65 in 234bf21

virtual ~Event() {}
T get_data() const { return data; }
}; // Class Event
// free the memory associated with the event
static void consume_event(GeneratedEventBase *e) { delete e; } 

!Line: 60 - style: The destructor '~Event' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride]

!Line: 43 - note: Virtual destructor in base class
!Line: 60 - note: Destructor in derived class

espp/components/state_machine/example/main/hfsm_example.cpp

Lines 28 to 33 in 234bf21

const espp::state_machine::Complex::GeneratedEventBase *e = nullptr;
bool handled = false;
// create the HFSM
espp::state_machine::Complex::Root complex_root; 

!Line: 28 - style: Variable 'e' is assigned a value that is never used. [unreadVariable]

espp/components/state_machine/example/main/hfsm_example.cpp

Lines 29 to 34 in 234bf21

bool handled = false;
// create the HFSM
espp::state_machine::Complex::Root complex_root;
// set the log callback to print to stdout 

!Line: 29 - style: Variable 'handled' is assigned a value that is never used. [unreadVariable]

espp/components/state_machine/example/main/hfsm_example.cpp

Lines 91 to 96 in 234bf21

const espp::state_machine::Complex::GeneratedEventBase *e = nullptr;
// create the HFSM
espp::state_machine::Complex::Root complex_root;
// set the log callback to print to stdout 

!Line: 91 - style: Variable 'e' is assigned a value that is never used. [unreadVariable]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/t-deck/example/main/t_deck_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/t-deck/src/t-deck.cpp

Lines 245 to 250 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = TDeck::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 245 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 287 - note: You might need to cast the function pointer here
!Line: 245 - note: Parameter 't' can be declared as pointer to const

espp/components/t-deck/src/t-deck.cpp

Lines 255 to 260 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 255 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 288 - note: You might need to cast the function pointer here
!Line: 255 - note: Parameter 't' can be declared as pointer to const

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/codec/es7210/es7210.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/task/include/run_on_core.hpp

Lines 54 to 59 in 234bf21

.callback = [&mutex, &cv, &f, &ret_val, &notified](auto &cb_m, auto &cb_cv) -> bool {
// synchronize with the main thread - block here until the main thread
// waits on the condition variable (cv), then run the function
std::unique_lock lock(mutex);
// run the function
ret_val = f(); 

!Line: 54 - style: Parameter 'cb_m' can be declared as reference to const [constParameterReference]

espp/components/task/include/run_on_core.hpp

Lines 54 to 59 in 234bf21

.callback = [&mutex, &cv, &f, &ret_val, &notified](auto &cb_m, auto &cb_cv) -> bool {
// synchronize with the main thread - block here until the main thread
// waits on the condition variable (cv), then run the function
std::unique_lock lock(mutex);
// run the function
ret_val = f(); 

!Line: 54 - style: Parameter 'cb_cv' can be declared as reference to const [constParameterReference]

espp/components/task/include/run_on_core.hpp

Lines 79 to 84 in 234bf21

.callback = [&mutex, &cv, &f, &notified](auto &cb_m, auto &cb_cv) -> bool {
// synchronize with the main thread - block here until the main thread
// waits on the condition variable (cv), then run the function
std::unique_lock lock(mutex);
// run the function
f(); 

!Line: 79 - style: Parameter 'cb_m' can be declared as reference to const [constParameterReference]

espp/components/task/include/run_on_core.hpp

Lines 79 to 84 in 234bf21

.callback = [&mutex, &cv, &f, &notified](auto &cb_m, auto &cb_cv) -> bool {
// synchronize with the main thread - block here until the main thread
// waits on the condition variable (cv), then run the function
std::unique_lock lock(mutex);
// run the function
f(); 

!Line: 79 - style: Parameter 'cb_cv' can be declared as reference to const [constParameterReference]

espp/components/codec/es8311/es8311.cpp

Lines 547 to 552 in 234bf21

adc_iface |= BIT(6);
dac_iface |= BIT(6);
if (mode == ES_MODULE_LINE) {
ESP_LOGE(TAG, "The codec es8311 doesn't support ES_MODULE_LINE mode");
return ESP_FAIL; 

!Line: 547 - error: syntax error [syntaxError]

https://github.com/esp-cpp/espp/blob/234bf210f41b866cdd4afa2ba02658a7fe847ff3/components/task/example/main/task_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/led_strip/example/main/led_strip_example.cpp

Lines 61 to 66 in 234bf21

rmt_encode_state_t *ret_state) -> size_t {
// divide the transmit resolution (10MHz) by 1,000,000 to get the
// number of ticks per microsecond
// we divide by two since we have both duration0 and duration1 in the
// reset code
static uint16_t reset_ticks = 

!Line: 61 - style: Parameter 'ret_state' can be declared as pointer to const [constParameterPointer]

espp/components/adc/include/oneshot_adc.hpp

Lines 153 to 158 in 234bf21

for (auto &conf : config.channels) {
auto channel = conf.channel;
auto attenuation = conf.attenuation;
auto channel_unit = conf.unit;
if (config.unit != channel_unit) {
logger_.warn("Channel configuration invalid, main unit ({}) != channel unit ({})", 

!Line: 153 - style: Variable 'conf' can be declared as reference to const [constVariableReference]

espp/components/adc/include/continuous_adc.hpp

Lines 173 to 178 in 234bf21

bool update_task(std::mutex &task_m, std::condition_variable &task_cv, bool &task_notified) {
task_handle_ = xTaskGetCurrentTaskHandle();
static auto previous_timestamp = std::chrono::high_resolution_clock::now();
// wait until conversion is ready (will be notified by the registered
ulTaskNotifyTake(pdTRUE, portMAX_DELAY);
auto current_timestamp = std::chrono::high_resolution_clock::now(); 

!Line: 173 - style: Parameter 'task_m' can be declared as reference to const. However it seems that 'update_task' is a callback function, if 'task_m' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 66 - note: You might need to cast the function pointer here
!Line: 173 - note: Parameter 'task_m' can be declared as reference to const

espp/components/adc/include/continuous_adc.hpp

Lines 173 to 178 in 234bf21

bool update_task(std::mutex &task_m, std::condition_variable &task_cv, bool &task_notified) {
task_handle_ = xTaskGetCurrentTaskHandle();
static auto previous_timestamp = std::chrono::high_resolution_clock::now();
// wait until conversion is ready (will be notified by the registered
ulTaskNotifyTake(pdTRUE, portMAX_DELAY);
auto current_timestamp = std::chrono::high_resolution_clock::now(); 

!Line: 173 - style: Parameter 'task_cv' can be declared as reference to const. However it seems that 'update_task' is a callback function, if 'task_cv' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 66 - note: You might need to cast the function pointer here
!Line: 173 - note: Parameter 'task_cv' can be declared as reference to const

espp/components/adc/include/continuous_adc.hpp

Lines 173 to 178 in 234bf21

bool update_task(std::mutex &task_m, std::condition_variable &task_cv, bool &task_notified) {
task_handle_ = xTaskGetCurrentTaskHandle();
static auto previous_timestamp = std::chrono::high_resolution_clock::now();
// wait until conversion is ready (will be notified by the registered
ulTaskNotifyTake(pdTRUE, portMAX_DELAY);
auto current_timestamp = std::chrono::high_resolution_clock::now(); 

!Line: 173 - style: Parameter 'task_notified' can be declared as reference to const. However it seems that 'update_task' is a callback function, if 'task_notified' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 66 - note: You might need to cast the function pointer here
!Line: 173 - note: Parameter 'task_notified' can be declared as reference to const

espp/components/display_drivers/include/sh8601.hpp

Lines 118 to 123 in 234bf21

if (swap_color_order_) {
madctl |= LCD_CMD_BGR_BIT;
}
if (mirror_x_) {
madctl |= LCD_CMD_MX_BIT;
} 

!Line: 118 - style: Condition 'swap_color_order_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 121 to 126 in 234bf21

if (mirror_x_) {
madctl |= LCD_CMD_MX_BIT;
}
if (mirror_y_) {
madctl |= LCD_CMD_MY_BIT;
} 

!Line: 121 - style: Condition 'mirror_x_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 124 to 129 in 234bf21

if (mirror_y_) {
madctl |= LCD_CMD_MY_BIT;
}
if (swap_xy_) {
madctl |= LCD_CMD_MV_BIT;
} 

!Line: 124 - style: Condition 'mirror_y_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 127 to 132 in 234bf21

if (swap_xy_) {
madctl |= LCD_CMD_MV_BIT;
}
auto init_cmds = std::to_array<display_drivers::DisplayInitCmd<Command>>({
{Command::slpout, {}, 120}, // sleep out 

!Line: 127 - style: Condition 'swap_xy_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 156 to 161 in 234bf21

if (swap_color_order_) {
data |= LCD_CMD_BGR_BIT;
}
if (mirror_x_) {
data |= LCD_CMD_MX_BIT;
} 

!Line: 156 - style: Condition 'swap_color_order_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 159 to 164 in 234bf21

if (mirror_x_) {
data |= LCD_CMD_MX_BIT;
}
if (mirror_y_) {
data |= LCD_CMD_MY_BIT;
} 

!Line: 159 - style: Condition 'mirror_x_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 162 to 167 in 234bf21

if (mirror_y_) {
data |= LCD_CMD_MY_BIT;
}
if (swap_xy_) {
data |= LCD_CMD_MV_BIT;
} 

!Line: 162 - style: Condition 'mirror_y_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 165 to 170 in 234bf21

if (swap_xy_) {
data |= LCD_CMD_MV_BIT;
}
switch (rotation) {
case DisplayRotation::LANDSCAPE: 

!Line: 165 - style: Condition 'swap_xy_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 174 to 179 in 234bf21

if (mirror_portrait_) {
data ^= (LCD_CMD_MX_BIT | LCD_CMD_MV_BIT);
} else {
data ^= (LCD_CMD_MY_BIT | LCD_CMD_MV_BIT);
}
break; 

!Line: 174 - style: Condition 'mirror_portrait_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 186 to 191 in 234bf21

if (mirror_portrait_) {
data ^= (LCD_CMD_MY_BIT | LCD_CMD_MV_BIT);
} else {
data ^= (LCD_CMD_MX_BIT | LCD_CMD_MV_BIT);
}
break; 

!Line: 186 - style: Condition 'mirror_portrait_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 117 to 122 in 234bf21

uint8_t madctl = 0;
if (swap_color_order_) {
madctl |= LCD_CMD_BGR_BIT;
}
if (mirror_x_) {
madctl |= LCD_CMD_MX_BIT; 

!Line: 117 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 119 to 124 in 234bf21

madctl |= LCD_CMD_BGR_BIT;
}
if (mirror_x_) {
madctl |= LCD_CMD_MX_BIT;
}
if (mirror_y_) { 

!Line: 119 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 122 to 127 in 234bf21

madctl |= LCD_CMD_MX_BIT;
}
if (mirror_y_) {
madctl |= LCD_CMD_MY_BIT;
}
if (swap_xy_) { 

!Line: 122 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 125 to 130 in 234bf21

madctl |= LCD_CMD_MY_BIT;
}
if (swap_xy_) {
madctl |= LCD_CMD_MV_BIT;
} 

!Line: 125 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 128 to 133 in 234bf21

madctl |= LCD_CMD_MV_BIT;
}
auto init_cmds = std::to_array<display_drivers::DisplayInitCmd<Command>>({
{Command::slpout, {}, 120}, // sleep out
{Command::noron}, // normal mode 

!Line: 128 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/example/main/display_drivers_example.cpp

Lines 59 to 64 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level((gpio_num_t)DC_PIN_NUM, dc_level);
}
#endif 

!Line: 59 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 505 - note: You might need to cast the function pointer here
!Line: 59 - note: Parameter 't' can be declared as pointer to const

espp/components/display_drivers/example/main/display_drivers_example.cpp

Lines 71 to 76 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 71 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 507 - note: You might need to cast the function pointer here
!Line: 71 - note: Parameter 't' can be declared as pointer to const

espp/components/seeed-studio-round-display/example/main/seeed_studio_round_display_example.cpp

Lines 152 to 157 in 234bf21

static void on_clear_pressed(lv_event_t *event) { clear_circles(); }
static void draw_circle(int x0, int y0, int radius) {
std::lock_guard<std::recursive_mutex> lock(lvgl_mutex);
// if the number of circles is greater than the max, remove the oldest circle
if (circles.size() > MAX_CIRCLES) { 

!Line: 152 - style: Parameter 'event' can be declared as pointer to const. However it seems that 'on_clear_pressed' is a callback function, if 'event' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 111 - note: You might need to cast the function pointer here
!Line: 152 - note: Parameter 'event' can be declared as pointer to const

espp/components/seeed-studio-round-display/src/seeed-studio-round-display.cpp

Lines 175 to 180 in 234bf21

static void IRAM_ATTR lcd_spi_pre_transfer_callback(spi_transaction_t *t) {
static auto lcd_dc_io = SsRoundDisplay::get_lcd_dc_gpio();
uint32_t user_flags = (uint32_t)(t->user);
bool dc_level = user_flags & DC_LEVEL_BIT;
gpio_set_level(lcd_dc_io, dc_level);
} 

!Line: 175 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_pre_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 217 - note: You might need to cast the function pointer here
!Line: 175 - note: Parameter 't' can be declared as pointer to const

espp/components/seeed-studio-round-display/src/seeed-studio-round-display.cpp

Lines 185 to 190 in 234bf21

static void IRAM_ATTR lcd_spi_post_transfer_callback(spi_transaction_t *t) {
uint16_t user_flags = (uint32_t)(t->user);
bool should_flush = user_flags & FLUSH_BIT;
if (should_flush) {
lv_display_t *disp = lv_display_get_default();
lv_display_flush_ready(disp); 

!Line: 185 - style: Parameter 't' can be declared as pointer to const. However it seems that 'lcd_spi_post_transfer_callback' is a callback function, if 't' is declared with const you might also need to cast function pointer(s). [constParameterCallback]

!Line: 218 - note: You might need to cast the function pointer here
!Line: 185 - note: Parameter 't' can be declared as pointer to const

espp/pc/tests/task.cpp

Lines 16 to 21 in 234bf21

espp::Task task({.name = "Task", .callback = [&](auto &m, auto &cv) -> bool {
auto now = std::chrono::steady_clock::now();
logger.info("[{:.3f}] Hello from the task!", elapsed());
std::this_thread::sleep_until(now + 1s);
// don't want to stop the task
return false; 

!Line: 16 - style: Parameter 'm' can be declared as reference to const [constParameterReference]

espp/pc/tests/task.cpp

Lines 16 to 21 in 234bf21

espp::Task task({.name = "Task", .callback = [&](auto &m, auto &cv) -> bool {
auto now = std::chrono::steady_clock::now();
logger.info("[{:.3f}] Hello from the task!", elapsed());
std::this_thread::sleep_until(now + 1s);
// don't want to stop the task
return false; 

!Line: 16 - style: Parameter 'cv' can be declared as reference to const [constParameterReference]

@finger563 finger563 self-assigned this Mar 3, 2025
@finger563 finger563 added enhancement New feature or request display labels Mar 3, 2025
@finger563 finger563 merged commit e220938 into main Mar 3, 2025
72 of 73 checks passed
@finger563 finger563 deleted the feat/display-callback-enhancement branch March 3, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@finger563 finger563

Labels
display enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@finger563