fix static analysis #393

finger563 · 2025-03-03T21:43:27Z

Description

Fix static analysis issues in the repo

Motivation and Context

After updating esp-cpp/StaticAnalysis to latest, more issues were found in SA in recent PRs, so this PR aims to fix those issues.

How has this been tested?

Building the examples.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update
Hardware (schematic, board, system design) change
Software change

Checklist:

My change requires a change to the documentation.
I have added / updated the documentation related to this change via either README or WIKI

Software

I have added tests to cover my changes.
I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
All new and existing tests passed.
My code follows the code style of this project.

github-actions · 2025-03-03T21:45:54Z

⚡ Static analysis result ⚡

🔴 cppcheck found 52 issues! Click here to see details.

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/ftp/include/ftp_client.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/cli/include/line_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/cli/include/cli.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/file_system/src/file_system.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/binary-log/example/main/binary_log_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/ble_gatt_server/include/ble_gatt_server_menu.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/ble_gatt_server/example/main/ble_gatt_server_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/event_manager/src/event_manager.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/hid_service/example/main/hid_service_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/color/src/color.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/input_drivers/include/touchpad_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/input_drivers/include/keypad_input.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/gt911/include/gt911.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/nvs/example/main/nvs_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/matouch-rotary-display/example/main/matouch_rotary_display_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/rtsp/include/jpeg_header.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/rtsp/include/rtsp_client.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/rtsp/include/rtsp_server.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/rtsp/include/jpeg_frame.hpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/monitor/example/main/monitor_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 656 to 661 in 975ade7

    
           State_2::ChildState COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ; 
        
           DeepHistoryState COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ; 
        
           State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ; 
        
           State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ; 
        
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ;

!Line: 656 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 240 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 656 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 657 to 662 in 975ade7

    
           DeepHistoryState COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ; 
        
           State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ; 
        
           State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ; 
        
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;

!Line: 657 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 241 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 657 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 658 to 663 in 975ade7

    
           State_2::ChildState2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ; 
        
           State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ; 
        
           State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ; 
        
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2 COMPLEX_OBJ__STATE_2_OBJ;

!Line: 658 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 242 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 658 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 659 to 664 in 975ade7

    
           State_2::ChildState3::Grand COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ; 
        
           State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ; 
        
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2 COMPLEX_OBJ__STATE_2_OBJ; 
        
           State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ;

!Line: 659 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 243 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.
!Line: 659 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 660 to 665 in 975ade7

    
           State_2::ChildState3::Grand2 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ; 
        
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2 COMPLEX_OBJ__STATE_2_OBJ; 
        
           State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ;

!Line: 660 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 245 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.
!Line: 660 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ__GRAND2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 661 to 666 in 975ade7

    
           State_2::ChildState3 COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2 COMPLEX_OBJ__STATE_2_OBJ; 
        
           State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ;

!Line: 661 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 247 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 661 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 662 to 667 in 975ade7

    
           ShallowHistoryState COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           State_2 COMPLEX_OBJ__STATE_2_OBJ; 
        
           State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ;

!Line: 662 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations. [initializerList]

!Line: 248 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.
!Line: 662 - note: Member variable 'Root::COMPLEX_OBJ__STATE_2_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE_2_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 664 to 669 in 975ade7

    
           State3::ChildState2 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ; 
        
           ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ; 
        
           State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ; 
        
           State3 COMPLEX_OBJ__STATE3_OBJ;

!Line: 664 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 250 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 664 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE2_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 665 to 670 in 975ade7

    
           ShallowHistoryState COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ; 
        
           DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ; 
        
           State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ; 
        
           State3 COMPLEX_OBJ__STATE3_OBJ; 
        
           // END state object

!Line: 665 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 251 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 665 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__SHALLOW_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 666 to 671 in 975ade7

    
           DeepHistoryState COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ; 
        
           State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ; 
        
           State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ; 
        
           State3 COMPLEX_OBJ__STATE3_OBJ; 
        
           // END state object 
        
           End_State COMPLEX_OBJ__END_STATE_OBJ;

!Line: 666 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 252 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 666 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__DEEP_HISTORY_PSEUDOSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 667 to 672 in 975ade7

    
           State3::ChildState COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ; 
        
           State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ; 
        
           State3 COMPLEX_OBJ__STATE3_OBJ; 
        
           // END state object 
        
           End_State COMPLEX_OBJ__END_STATE_OBJ; 
        
           // Keep a _root for easier templating, it will point to us

!Line: 667 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 253 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 667 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 668 to 673 in 975ade7

    
           State3::ChildState3 COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ; 
        
           State3 COMPLEX_OBJ__STATE3_OBJ; 
        
           // END state object 
        
           End_State COMPLEX_OBJ__END_STATE_OBJ; 
        
           // Keep a _root for easier templating, it will point to us 
        
           Root *_root;

!Line: 668 - style: inconclusive: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations. [initializerList]

!Line: 254 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.
!Line: 668 - note: Member variable 'Root::COMPLEX_OBJ__STATE3_OBJ__CHILDSTATE3_OBJ' uses an uninitialized argument 'COMPLEX_OBJ__STATE3_OBJ' due to the order of declarations.

espp/components/state_machine/example/main/Complex_generated_states.hpp

Lines 60 to 65 in 975ade7

    
             virtual ~Event() {} 
        
             T get_data() const { return data; } 
        
           }; // Class Event 
        
           // free the memory associated with the event 
        
           static void consume_event(GeneratedEventBase *e) { delete e; }

!Line: 60 - style: The destructor '~Event' overrides a destructor in a base class but is not marked with a 'override' specifier. [missingOverride]

!Line: 43 - note: Virtual destructor in base class
!Line: 60 - note: Destructor in derived class

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/t-deck/example/main/t_deck_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/codec/es7210/es7210.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/codec/es8311/es8311.cpp

Lines 547 to 552 in 975ade7

    
           adc_iface |= BIT(6); 
        
           dac_iface |= BIT(6); 
        
           if (mode == ES_MODULE_LINE) { 
        
             ESP_LOGE(TAG, "The codec es8311 doesn't support ES_MODULE_LINE mode"); 
        
             return ESP_FAIL;

!Line: 547 - error: syntax error [syntaxError]

https://github.com/esp-cpp/espp/blob/975ade7b7a74c42c4253fe0ef9b482e48c412668/components/task/example/main/task_example.cpp#L0-L5

!Line: 0 - information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches]

espp/components/display_drivers/include/sh8601.hpp

Lines 118 to 123 in 975ade7

    
           if (swap_color_order_) { 
        
             madctl |= LCD_CMD_BGR_BIT; 
        
           } 
        
           if (mirror_x_) { 
        
             madctl |= LCD_CMD_MX_BIT; 
        
           }

!Line: 118 - style: Condition 'swap_color_order_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 121 to 126 in 975ade7

    
           if (mirror_x_) { 
        
             madctl |= LCD_CMD_MX_BIT; 
        
           } 
        
           if (mirror_y_) { 
        
             madctl |= LCD_CMD_MY_BIT; 
        
           }

!Line: 121 - style: Condition 'mirror_x_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 124 to 129 in 975ade7

    
           if (mirror_y_) { 
        
             madctl |= LCD_CMD_MY_BIT; 
        
           } 
        
           if (swap_xy_) { 
        
             madctl |= LCD_CMD_MV_BIT; 
        
           }

!Line: 124 - style: Condition 'mirror_y_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 127 to 132 in 975ade7

    
           if (swap_xy_) { 
        
             madctl |= LCD_CMD_MV_BIT; 
        
           } 
        
           auto init_cmds = std::to_array<display_drivers::DisplayInitCmd<Command>>({ 
        
               {Command::slpout, {}, 120},                                // sleep out

!Line: 127 - style: Condition 'swap_xy_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 156 to 161 in 975ade7

    
           if (swap_color_order_) { 
        
             data |= LCD_CMD_BGR_BIT; 
        
           } 
        
           if (mirror_x_) { 
        
             data |= LCD_CMD_MX_BIT; 
        
           }

!Line: 156 - style: Condition 'swap_color_order_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 159 to 164 in 975ade7

    
           if (mirror_x_) { 
        
             data |= LCD_CMD_MX_BIT; 
        
           } 
        
           if (mirror_y_) { 
        
             data |= LCD_CMD_MY_BIT; 
        
           }

!Line: 159 - style: Condition 'mirror_x_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 162 to 167 in 975ade7

    
           if (mirror_y_) { 
        
             data |= LCD_CMD_MY_BIT; 
        
           } 
        
           if (swap_xy_) { 
        
             data |= LCD_CMD_MV_BIT; 
        
           }

!Line: 162 - style: Condition 'mirror_y_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 165 to 170 in 975ade7

    
           if (swap_xy_) { 
        
             data |= LCD_CMD_MV_BIT; 
        
           } 
        
           switch (rotation) { 
        
           case DisplayRotation::LANDSCAPE:

!Line: 165 - style: Condition 'swap_xy_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 174 to 179 in 975ade7

    
           if (mirror_portrait_) { 
        
             data ^= (LCD_CMD_MX_BIT | LCD_CMD_MV_BIT); 
        
           } else { 
        
             data ^= (LCD_CMD_MY_BIT | LCD_CMD_MV_BIT); 
        
           } 
        
           break;

!Line: 174 - style: Condition 'mirror_portrait_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 186 to 191 in 975ade7

    
           if (mirror_portrait_) { 
        
             data ^= (LCD_CMD_MY_BIT | LCD_CMD_MV_BIT); 
        
           } else { 
        
             data ^= (LCD_CMD_MX_BIT | LCD_CMD_MV_BIT); 
        
           } 
        
           break;

!Line: 186 - style: Condition 'mirror_portrait_' is always false [knownConditionTrueFalse]

espp/components/display_drivers/include/sh8601.hpp

Lines 117 to 122 in 975ade7

    
           uint8_t madctl = 0; 
        
           if (swap_color_order_) { 
        
             madctl |= LCD_CMD_BGR_BIT; 
        
           } 
        
           if (mirror_x_) { 
        
             madctl |= LCD_CMD_MX_BIT;

!Line: 117 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 119 to 124 in 975ade7

    
             madctl |= LCD_CMD_BGR_BIT; 
        
           } 
        
           if (mirror_x_) { 
        
             madctl |= LCD_CMD_MX_BIT; 
        
           } 
        
           if (mirror_y_) {

!Line: 119 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 122 to 127 in 975ade7

    
             madctl |= LCD_CMD_MX_BIT; 
        
           } 
        
           if (mirror_y_) { 
        
             madctl |= LCD_CMD_MY_BIT; 
        
           } 
        
           if (swap_xy_) {

!Line: 122 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 125 to 130 in 975ade7

    
             madctl |= LCD_CMD_MY_BIT; 
        
           } 
        
           if (swap_xy_) { 
        
             madctl |= LCD_CMD_MV_BIT; 
        
           }

!Line: 125 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

espp/components/display_drivers/include/sh8601.hpp

Lines 128 to 133 in 975ade7

    
             madctl |= LCD_CMD_MV_BIT; 
        
           } 
        
           auto init_cmds = std::to_array<display_drivers::DisplayInitCmd<Command>>({ 
        
               {Command::slpout, {}, 120},                                // sleep out 
        
               {Command::noron},                                          // normal mode

!Line: 128 - style: Variable 'madctl' is assigned a value that is never used. [unreadVariable]

fix static analysis

799471d

finger563 self-assigned this Mar 3, 2025

finger563 added bug Something isn't working static analysis chore labels Mar 3, 2025

finger563 added 8 commits March 3, 2025 15:47

update to analyze all branches

c84f81c

fix led_strip example build

2f23217

remove goto from example

957213f

remove recursive clone from sa and all the additional ignores it requres

e56dcd1

add pull request trigger as well

fd260eb

disable pull request target for now -.-

daedd9e

revert

975ade7

fix examples

ec8ae3f

finger563 merged commit 7281900 into main Mar 3, 2025
72 of 73 checks passed

finger563 deleted the fix/sa branch March 3, 2025 23:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix static analysis #393

fix static analysis #393

finger563 commented Mar 3, 2025

github-actions bot commented Mar 3, 2025 •

edited

Loading

fix static analysis #393

fix static analysis #393

Conversation

finger563 commented Mar 3, 2025

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

Checklist:

Software

github-actions bot commented Mar 3, 2025 • edited Loading

⚡ Static analysis result ⚡

github-actions bot commented Mar 3, 2025 •

edited

Loading