Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp-box): Add interrupts for mute and boot buttons #398

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

finger563
Copy link
Contributor

Description

  • Update esp-box to have optional registration of interrupt callbacks for mute and boot buttons
  • Update esp-box to check sound initialized before dealing with sound functions
  • Update qtpy to only register button interrupt if not already registered

Motivation and Context

Fleshes out more of the hardware functionality in esp-box; ensures the API cannot be misued and handles cases where mute button is initialized but sound is not.

How has this been tested?

Building esp-box and qtpy examples.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update esp-box to have optional registration of interrupt callbacks for mute and boot buttons
* Update esp-box to check sound initialized before dealing with sound functions
* Update qtpy to only register button interrupt if not already registered

Fleshes out more of the hardware functionality in esp-box; ensures the API cannot be misued and handles cases where mute button is initialized but sound is not.
@finger563 finger563 self-assigned this Mar 7, 2025
@finger563 finger563 added enhancement New feature or request esp-box qtpy labels Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit a3bea08 into main Mar 7, 2025
75 checks passed
@finger563 finger563 deleted the feat/esp-box-buttons branch March 7, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request esp-box qtpy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant