Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motorgo-mini): Replace use of espp::Button with espp::Interrupt #403

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Mar 8, 2025

Description

Replace espp::Button with use of espp::Interrupt to better mirror other BSP compoennts.

Motivation and Context

Using interrupt provides both the ability to read the state as well as register callback when the state changes. Using the interrupt class for this instead of the button class allows the user to register additional interrupts should they like, without needing to spawn additional tasks.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Mar 8, 2025
@finger563 finger563 added enhancement New feature or request motorgo mini labels Mar 8, 2025
Copy link

github-actions bot commented Mar 8, 2025

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit f055868 into main Mar 8, 2025
75 checks passed
@finger563 finger563 deleted the feat/motorgo-mini-button-interrupt branch March 8, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request motorgo mini
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant