Skip to content

feat(wifi): Allow configuration of wifi phy rate for AP and STA #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Aug 13, 2025

Description

  • Add wifi_phy_rate_t phy_rate to espp::WifiAp::Config and espp::WifiSta::Config which defaults to WIFI_PHY_RATE_MCS0_LGI - 6.5 - 13.5 Mbps.
  • Add additional debug logs for consistency.
  • Add format helper for libfmt printing of wifi_phy_rate_t
  • Update example to have DEBUG logging on for WiFi AP.

Motivation and Context

Allows the user to set the PHY rate for the WiFi AP and STA configurations. This can be useful for optimizing performance or compatibility with specific devices.

How has this been tested?

  • Build and run wifi/example on QtPy ESP32-S3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2025-08-13 at 10 11 44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Aug 13, 2025
@finger563 finger563 requested a review from Copilot August 13, 2025 15:16
@finger563 finger563 added enhancement New feature or request wifi labels Aug 13, 2025
Copy link

✅Static analysis result - no issues found! ✅

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PHY rate configuration support to both WiFi Access Point and Station modes, allowing users to configure the transmission rate for optimization of performance or compatibility.

  • Adds wifi_phy_rate_t phy_rate configuration option to both WifiAp::Config and WifiSta::Config structures
  • Implements comprehensive format helpers for debug logging of PHY rate values
  • Enhances debugging capabilities with additional logging statements

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
wifi_sta.hpp Adds PHY rate configuration to STA config and enhanced debug logging
wifi_format_helpers.hpp New format helper for libfmt printing of wifi_phy_rate_t enum values
wifi_ap.hpp Adds PHY rate configuration to AP config with debug logging
wifi_example.cpp Updates example to enable DEBUG logging for WiFi AP

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@finger563 finger563 merged commit adfff25 into main Aug 13, 2025
91 of 93 checks passed
@finger563 finger563 deleted the feat/wifi-phy-rate branch August 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wifi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant