WIP: Build, wrap and upload stubs as artifacts for PRs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNedic
force-pushed
the
pr_build_artifacts
branch
2 times, most recently
from
5dda1f5 to
43a077d
Compare
This will help test new changes in tools/libraries which use the flasher stub like esp-serial-flasher or esptool.
DNedic
force-pushed
the
pr_build_artifacts
branch
from
43a077d to
0080b32
Compare
|
With the current setup, the user would have to specify a link to every chip output artifact. Also, the artifacts are zipped, unlike with the releases. I will explore what can be done to make this more convenient. |
|
Closing this as another way to override stub sources with local files was chosen for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By uploading built and wrapped stubs as artifacts for PRs, we can point tools and libraries like
esp-serial-flasherandesptoolto these in order to do integration testing.