Skip to content

Commit

Permalink
Fix LCD_CAM i8080 potentially sending garbage data to display (#1301)
Browse files Browse the repository at this point in the history
  • Loading branch information
yanshay authored Mar 26, 2024
1 parent 9b64e64 commit f18e8ae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions esp-hal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- ESP32: Apply fix for Errata 3.6 in all the places necessary. (#1315)
- ESP32 & ESP32-S2: Fix I²C frequency (#1306)
- UART's TX/RX FIFOs are now cleared during initialization (#1344)
- Fixed `LCD_CAM I8080` driver potentially sending garbage to display (#1301)


### Changed

Expand Down
4 changes: 4 additions & 0 deletions esp-hal/src/lcd_cam/lcd/i8080.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,10 @@ impl<'d, TX: Tx, P> I8080<'d, TX, P> {
.lc_dma_int_clr()
.write(|w| w.lcd_trans_done_int_clr().set_bit());

// Before issuing lcd_start need to wait shortly for fifo to get data
// Otherwise, some garbage data will be sent out
crate::rom::ets_delay_us(1);

self.lcd_cam
.lcd_user()
.modify(|_, w| w.lcd_update().set_bit().lcd_start().set_bit());
Expand Down

0 comments on commit f18e8ae

Please sign in to comment.