Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lto = 'fat' + RISCV interrupts results in changed binding to STB_GLOBAL linker errors #1326

Closed
MabezDev opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@MabezDev
Copy link
Member

It seems this is specific to LTO.

  • esp-riscv-rt defines cpu_int_x_handler as weak symbols
  • esp-hal defines some cpu_int_x_handler handlers as global symbols to override the weak symbols for vectoring

It seems with lto = 'fat both the weakly linked symbols and the strong symbols end up in the same codegen unit and LLVM complains about the binding changing, but in reality the binding change is actually some global symbols that can resolve weaker ones.

@MabezDev
Copy link
Member Author

Closed via #1327

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant