discard interrupt symbols from lto so that lto doesn't end up rebinding them #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
commented
Mar 21, 2024
| .weak cpu_int_31_handler | ||
| // See https://github.com/esp-rs/esp-hal/issues/1326 and https://reviews.llvm.org/D98762 | ||
| // and yes, this all has to go on one line... *sigh*. | ||
| .lto_discard interrupt1, interrupt2, interrupt3, interrupt4, interrupt5, interrupt6, interrupt7, interrupt8, interrupt9, interrupt10, interrupt11, interrupt12, interrupt13, interrupt14, interrupt15, interrupt16, interrupt17, interrupt18, interrupt19, interrupt20, interrupt21, interrupt22, interrupt23, interrupt24, interrupt25, interrupt26, interrupt27, interrupt28, interrupt29, interrupt30, interrupt31 |
There was a problem hiding this comment.
decided to rename them all interruptX to be consistent with xtensa, and also because this line was massive (still is but 🤷)
MabezDev
commented
Mar 21, 2024
| debug-assertions = false | ||
| incremental = false | ||
| opt-level = 3 | ||
| lto = 'fat' |
There was a problem hiding this comment.
Building examples with fat lto now, we may as well use the best settings available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Details in #1326
Testing
Uncomment the lto_discard line and build either hil-test or an example on esp32c3 etc and it will exhibit the linker failure.