Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct errata36() for gpio 32 and 33 #1053

Merged
merged 2 commits into from
Dec 28, 2023
Merged

correct errata36() for gpio 32 and 33 #1053

merged 2 commits into from
Dec 28, 2023

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Dec 27, 2023 •
edited
Loading

The datasheet in page 14 table 2-1 lists 32K_XP as gpio32 and 32K_XN as gpio33 but these were swapped in errata36().
This PR corrects that.

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@liebman liebman marked this pull request as ready for review December 27, 2023 23:36
@liebman liebman mentioned this pull request Dec 27, 2023
Closed
bjoernQ
bjoernQ approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix!

@bjoernQ bjoernQ added this pull request to the merge queue Dec 28, 2023
Merged via the queue into esp-rs:main with commit 2e2d67f Dec 28, 2023
17 checks passed
@liebman liebman deleted the fix-pull-modes-for-gpio-32-and-33 branch December 28, 2023 12:59
Volkalex28 pushed a commit to Volkalex28/esp-hal that referenced this pull request Feb 6, 2024
@liebman @Volkalex28
correct errata36() for gpio 32 and 33 (esp-rs#1053)
0c8db48 
* correct errata36() for gpio 32 and 33

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liebman @bjoernQ