Add rt-riscv and rt-xtensa features to esp-hal-common
#1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabling/disable runtime support
…t default features
bjoernQ
reviewed
Jan 3, 2024
| @@ -48,7 +48,8 @@ embassy-sync = { version = "0.5.0", optional = true } | |||
| embassy-time = { version = "0.2.0", optional = true } | |||
|
|
|||
| # RISC-V | |||
| esp-riscv-rt = { version = "0.6.0", optional = true, path = "../esp-riscv-rt" } | |||
| riscv = { version = "0.10.1", optional = true } | |||
There was a problem hiding this comment.
is this just to make it look more aligned with Xtensa? Before we just used the re-export from esp-riscv-rt
There was a problem hiding this comment.
The critical section implementation uses riscv, which wasn't available if the rt-riscv feature is not enabled. So I've simply included the riscv dependency directly rather than using the re-exported version from esp-riscv-rt.
|
I also see no way to unify the |
MabezDev
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an ideal solution, but it's not immediately obvious how we would unify these features to me. Happy to make any changes if anybody has a better solution. This should be enough to close #579 at least, though.
Once this gets merged I can rebase #1049 on top of it and wrap that up, too.