-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 80Mhz psram, selected using 'psram-80mhz' feature #1073
Conversation
Thanks! This seems to work fine for me However, the new features need to get documented here: esp-hal/esp32s3-hal/src/lib.rs Lines 8 to 45 in 6afc988
Also, we should mention there that it's for qspi RAM only, currently |
I can add it to the qspi as well, it should work. Where I read about this it was in context of qspi, but I can't test it to work. To add it there as well? |
Yes, that would also be good. I don't think I have hardware to test 80MHz OSPI but the code would support it |
Added 80Mhz suppoort to octal psram and documetnation to lib.rs |
* Add `embedded-io` feature to each chip-specific HAL * Update `CHANGELOG.md`
* Update to `1.0.0` releases of `embedded-hal-*` packages * Update `CHANGELOG.md`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
Added support for 80Mhz PSRAM Bus as discussed in #1069
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have