Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPIO4 an InputOutputAnalog pin on ESP32 #1079

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Make GPIO4 an InputOutputAnalog pin on ESP32 #1079

merged 3 commits into from
Jan 12, 2024

Conversation

hansingt
Copy link
Contributor

@hansingt hansingt commented Jan 12, 2024

This allows using the GPIO Pin4 as an AnalogPin on ESP32 modules. According to the technical reference manual, GPIO4 is Channel 0 of ADC2. But before this change, it was not usable as such, as it did not implement the IsAnalogPin trait.

/closes #1078

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Jan 12, 2024
Merged via the queue into esp-rs:main with commit 944ce9a Jan 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESP32] GPIO4 not usable as analog pin for ADC
2 participants