Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the ADC constructor to new, make it infallible #1133

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Rename the ADC constructor to new, make it infallible #1133

merged 2 commits into from
Feb 1, 2024

Conversation

jessebraham
Copy link
Member

I somehow missed this in #1100, but just giving ADC the same treatment that DAC got with respect to its constructor.

bjoernQ
bjoernQ approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SergioGasquez
SergioGasquez approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MabezDev MabezDev added this pull request to the merge queue Feb 1, 2024
Merged via the queue into esp-rs:main with commit a586cb3 Feb 1, 2024
17 checks passed
@jessebraham jessebraham deleted the refactor/adc branch February 1, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

@JurajSadel JurajSadel Awaiting requested review from JurajSadel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessebraham @bjoernQ @SergioGasquez @MabezDev