Examples and test cleanup #1590
Conversation
|
Are the deleted examples going to become tests? Otherwise I don't see benefit in losing them. The eh1 SPI examples, aren't they useful to demonstrate how to get from a HAL type to an eh1 trait object? (I'm a bit biased since I'm trying to avoid merge conflicts 😅) |
Most already are, at least the crypto stuff is tested, and I converted the direct vectoring example to an interrupt latency test. The other examples IMO do not add that much value, I don't personally see the value in an example that does the same as another but imports eh to do so. |
* initial cull of examples * Remove direct vector example, replace with interrupt latency test * Remove clock monitor in favour of just a test --------- Co-authored-by: Jesse Braham <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MabezDev
force-pushed
the
examples-and-test-cleanup
branch
from
7734644 to
16695e7
Compare
MabezDev
force-pushed
the
examples-and-test-cleanup
branch
from
16695e7 to
b2aa8f5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MabezDev
force-pushed
the
examples-and-test-cleanup
branch
from
b2aa8f5 to
14d0c6e
Compare
* initial cull of examples * Remove direct vector example, replace with interrupt latency test * Remove clock monitor in favour of just a test
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This test seems pretty flaky, maybe we should skip it for the time being, just for the sake of getting the other changes merged? |
|
The thing is I'm quite confused as to why there is more latency than I see running it locally 🤔. I thought about doing a few runs, but actually, the first-time latency is an important metric in its own right. I think I'll just set a high enough number for now so that it passes; it will still catch interrupts not working at all for example as the test will time out. |
MabezDev
force-pushed
the
examples-and-test-cleanup
branch
from
14d0c6e to
4b976e7
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Closes #1436
Opening a bit before finishing (I plan on polishing some of the remaining examples) but I wanted to get opinions on the examples I nuked, and the ones I've kept so far.