Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up UART #2132

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Clean up UART #2132

merged 2 commits into from
Sep 10, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 10, 2024 •
edited
Loading

  • Drop unnecessary constructors
  • Drop unnecessary default pin types
    • These aren't very useful as we need to know their numbers anyway
  • Reduce the number of pin connection implementations, in preparation for GPIO interconnect #2128

@bugadani bugadani force-pushed the uart branch 5 times, most recently from f2b9f29 to fe0f0ec Compare September 10, 2024 13:06
@bjoernQ
Copy link
Contributor

bjoernQ commented Sep 10, 2024

I guess people could figure it out on their own but should we mention how to migrate code using *_with_default_pins in the migration guide?

bjoernQ
bjoernQ approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

MabezDev
MabezDev approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Sep 10, 2024
Merged via the queue into esp-rs:main with commit 9f5a57d Sep 10, 2024
27 checks passed
@bugadani bugadani deleted the uart branch September 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominaezzz Dominaezzz Dominaezzz left review comments

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @bjoernQ @MabezDev @Dominaezzz