-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix I2S examples #2139
Fix I2S examples #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that in #2074 everything (as in, inputs and outputs of the macro defintion) got swapped except for these values. Good find!
Having said that, it looks like lcd_cam, lcd_i8080, parl_io and qspi_flash examples may be similarly affected, and the migration guide should include how to update code using the asymmetric macros. Would you tackle these in this PR, or should we do them in a follow-up? |
Oh yes 🙈 - good catch Will address this in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Well, this was a very easy one
The macros to conveniently create descriptors and buffers were changed to RX-TX but in the example code the requested buffer size wasn't swapped in the parameter list of the macro invocation
No changelog - just examples changed
Testing
The changed examples work, again