Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase DMA type params #2261

Merged
merged 36 commits into from
Oct 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
394ff02
Split PdmaChannel into two
bugadani Oct 1, 2024
1c9fed0
Take &self in PDMA traits
bugadani Oct 1, 2024
2e1f3a9
Implement type-erased PDMA channels
bugadani Oct 1, 2024
b561a43
Remove Degraded assoc type
bugadani Oct 1, 2024
ebac0ab
Move degrade fns to base trait
bugadani Oct 1, 2024
c8ab220
Use PeripheralDmaChannel on constructors only
bugadani Oct 1, 2024
68c13cd
Remove WithDmaAes use
bugadani Oct 1, 2024
8a1bcc7
Erase DMA type params
bugadani Oct 2, 2024
a88bf54
Clean up examples/tests
bugadani Oct 2, 2024
2b8253a
Remove redundant trait bounds
bugadani Oct 3, 2024
b591eb6
Remove peripheral-specific DMA traits
bugadani Oct 3, 2024
7bafec9
Document i2s change
bugadani Oct 3, 2024
9111e56
Clean up parl_io
bugadani Oct 3, 2024
dd4605d
Deduplicate InterruptAccess
bugadani Oct 3, 2024
0e5a20f
Fix cfg
bugadani Oct 3, 2024
d2e3a4b
Implement runtime compatibility check
bugadani Oct 3, 2024
f750078
Clean up a bit
bugadani Oct 4, 2024
851c8fc
Document changes
bugadani Oct 4, 2024
a01b47c
Swap Channel type params, erase dma channel
bugadani Oct 4, 2024
a019533
Unsplit traits
bugadani Oct 4, 2024
a5cc2f3
Remove redundant cfg
bugadani Oct 4, 2024
4a91bfa
Fix docs
bugadani Oct 7, 2024
8865e99
Simplify DmaEligible
bugadani Oct 7, 2024
c705854
Remove unsafe code
bugadani Oct 7, 2024
f3c4cec
Revert "Swap Channel type params, erase dma channel"
bugadani Oct 7, 2024
ebf93db
Allow different degraded DMA types
bugadani Oct 7, 2024
4582667
Allow converting into peripheral-specific DMA channel, use it for com…
bugadani Oct 7, 2024
3c4e934
Erase PDMA types without AnyPdmaChannel
bugadani Oct 7, 2024
b9c0eb6
Hide degrade fns for now, remove from MG
bugadani Oct 7, 2024
be8ed88
Clean up SPI slave
bugadani Oct 7, 2024
a09efe9
Fix QSPI test
bugadani Oct 7, 2024
bc76e6b
Fix mem2mem, fix S3 peripherals
bugadani Oct 7, 2024
d14714d
Fix S2
bugadani Oct 7, 2024
52c500a
Remove AnyPdmaChannel
bugadani Oct 7, 2024
20fa92d
Remove PeripheralDmaChannel
bugadani Oct 8, 2024
7058e67
Remove unnecessary degrade call
bugadani Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix docs
bugadani committed Oct 8, 2024
commit 4a91bfaee0038fa43a093088a3211aa0bb8bd3d0
4 changes: 2 additions & 2 deletions esp-hal/src/spi/master.rs
Original file line number Diff line number Diff line change
@@ -490,9 +490,9 @@ where
T: InstanceDma,
M: DuplexMode,
{
/// Configures the SPI3 instance to use DMA with the specified channel.
/// Configures the SPI instance to use DMA with the specified channel.
///
/// This method prepares the SPI instance for DMA transfers using SPI3
/// This method prepares the SPI instance for DMA transfers using SPI
/// and returns an instance of `SpiDma` that supports DMA
/// operations.
pub fn with_dma<CH, DmaMode>(