I2c rename, small docs clean up #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
docs
branch
2 times, most recently
from
5805002 to
25e4e3a
Compare
bugadani
reviewed
Oct 9, 2024
esp-hal/src/prelude.rs
Outdated
| @@ -6,36 +6,46 @@ | |||
| //! things, particularly traits, which are used in almost every single Rust | |||
| //! program. | |||
|
|
|||
| pub use fugit::{ExtU64 as _fugit_ExtU64, RateExtU32 as _fugit_RateExtU32}; | |||
| pub use nb; | |||
| pub use prelude::*; | |||
There was a problem hiding this comment.
What's the result of this?
There was a problem hiding this comment.
Imo seeing what's actually in the prelude in the docs isn't that helpful, but I'm happy to revert if you feel differently.
There was a problem hiding this comment.
Eh whatever, I'd probably refrain from reexporting any of the things that you hid anyway.
|
Skip changelog for fixing esp-wifi lint |
MabezDev
force-pushed
the
docs
branch
3 times, most recently
from
61175c6 to
b726c9f
Compare
bugadani
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Just some bits I noticed reviewing our docs, the important one being the
I2C=>I2cchange.