feat(esp-wifi): Implement serde:{Deserialize, Serialize}
for wifi structs
#2346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Since support for
embedded-svc
was dropped in fd57488, code that previously relied on those traits can migrate to the equivalent fromesp-wifi
. Except that traits inembedded-svc
implementserde::{Serialize, Deserialize}
, so it was not a drop-in equivalent. This PR adds this functionality.no-std-net
is currently broken when building with serde (See:cargo check --no-default-features --features serde
broken on master dunmatt/no-std-net#15), I decided to remove it and usecore::net
types instead.EapClientConfiguration
uses'static
as lifetimes, so I had to use#[serde(skip)]
for it. If a'static
lifetime isn't a strict requirement, it would be easier to loosen the lifetime.Testing
I tested in a custom app I'm developing that this works as a drop-in replacement after implementing the serde traits.