Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PeripheralMarker #2468

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Remove PeripheralMarker #2468

merged 2 commits into from
Nov 7, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 6, 2024

This PR untangles the dma module from peripherals that don't use/support it, by removing PeripheralMarker.

@bugadani bugadani added the skip-changelog No changelog modification needed label Nov 6, 2024
@MabezDev
Copy link
Member

MabezDev commented Nov 7, 2024

Could we drop everything but the last commit here, so we can unblock the P4 PR?

@bugadani bugadani marked this pull request as ready for review November 7, 2024 12:16
@bugadani bugadani requested a review from MabezDev November 7, 2024 12:17
MabezDev
MabezDev approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just curious about hiding from the docs

esp-hal/src/twai/mod.rs Outdated Show resolved Hide resolved
playfulFence
playfulFence approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, gdma was already cfg-d out from P4 PR!

@bugadani bugadani enabled auto-merge November 7, 2024 13:30
@bugadani bugadani added this pull request to the merge queue Nov 7, 2024
Merged via the queue into esp-rs:main with commit ac819fb Nov 7, 2024
28 checks passed
@bugadani bugadani deleted the marker branch November 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@playfulFence playfulFence playfulFence approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @MabezDev @playfulFence