Add validation to esp-config
#2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Nov 7, 2024
bugadani
reviewed
Nov 7, 2024
bugadani
reviewed
Nov 7, 2024
jessebraham
added
status:blocked
jessebraham
force-pushed
the
feature/esp-config
branch
from
94f0812 to
4580560
Compare
bjoernQ
approved these changes
Nov 12, 2024
bugadani
approved these changes
Nov 12, 2024
| .join(format!("{prefix}config_table.md")) | ||
| .to_string_lossy() | ||
| .join(format!("{prefix}_config_table.md")) | ||
| .display() |
There was a problem hiding this comment.
I don't think I understand why we convert a PathBuf into a string before we pass it to something that needs an AsRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft, as this will need rebasing and additional changes once #2422 and #2246 get merged.
I have not actually taken advantage of the validation in any of the packages depending on
esp-config, not sure if that should be considered in-scope for this or be handled in a subsequent PR. Will take some time to do this.skip-changelogadded as theesp-configpackage does not have aCHANGELOG.md, and there are no user-facing changes here.Closes #2206