Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak guidelines #2482

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Tweak guidelines #2482

merged 3 commits into from
Nov 8, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 7, 2024

No description provided.

@bugadani bugadani added documentation Improvements or additions to documentation skip-changelog No changelog modification needed labels Nov 7, 2024
@bugadani bugadani marked this pull request as ready for review November 7, 2024 14:49
MabezDev
MabezDev previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was just adding to some of these myself, I'll dedup and submit mine seperately

documentation/API-GUIDELINES.md Show resolved Hide resolved
JurajSadel
JurajSadel approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
One idea, do you think it makes sense to mention one of our drivers to use as an template? What I mean is to reduce the chance of using bad driver as an example for new contributors.

@MabezDev
Copy link
Member

MabezDev commented Nov 7, 2024

One idea, do you think it makes sense to mention one of our drivers to use as an template? What I mean is to reduce the chance of using bad driver as an example for new contributors.

This is a great idea! However I don't think we're quite there for a reference driver, but we should definitely circle back to this in a few weeks once a few of the RFCs have been resolved and applied to a driver.

@bugadani bugadani dismissed MabezDev’s stale review November 7, 2024 15:31

I want to prevent myself from merging this until discussions are resolved.

Dominaezzz
Dominaezzz reviewed Nov 7, 2024
View reviewed changes
documentation/API-GUIDELINES.md Outdated Show resolved Hide resolved
documentation/API-GUIDELINES.md Outdated Show resolved Hide resolved
documentation/API-GUIDELINES.md Show resolved Hide resolved
documentation/API-GUIDELINES.md Outdated Show resolved Hide resolved
documentation/API-GUIDELINES.md Show resolved Hide resolved
@bugadani bugadani requested a review from MabezDev November 8, 2024 11:40
MabezDev
MabezDev approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bugadani bugadani added this pull request to the merge queue Nov 8, 2024
Merged via the queue into esp-rs:main with commit 31d714a Nov 8, 2024
28 checks passed
@bugadani bugadani deleted the docs branch November 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominaezzz Dominaezzz Dominaezzz left review comments

@JurajSadel JurajSadel JurajSadel approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @MabezDev @Dominaezzz @JurajSadel