Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIL(QOL): Use global timeout instead of timeout macros #2489

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

JurajSadel
Copy link
Contributor

No description provided.

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Nov 8, 2024
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be cool to have a default timeout that we could set. Thanks!

@bugadani
Copy link
Contributor

bugadani commented Nov 8, 2024

I'd prefer investing into probe-rs/embedded-test#3 instead.

@jessebraham
Copy link
Member

I'd prefer investing into probe-rs/embedded-test#3 instead.

Thanks for pointing that out, was going to suggest opening an issue upstream.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 8, 2024

I guess probe-rs/embedded-test#3 is the best way to go (is no timeout at all ever a good idea ....?)

So, what should happen with this PR? Does it solve a real problem we have currently? (Then we might want to get it in until we have a global timeout)

@bugadani
Copy link
Contributor

bugadani commented Nov 8, 2024

(is no timeout at all ever a good idea ....?)

The default is 30 seconds right now, there is no such thing as no timeout in embedded-test.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 8, 2024

(is no timeout at all ever a good idea ....?)

The default is 30 seconds right now, there is no such thing as no timeout in embedded-test.

Oh good - I never had the patience to wait 30 secs .... I don't see where the code sets 30 secs if None but I didn't try hard to find it

@bugadani
Copy link
Contributor

bugadani commented Nov 8, 2024

My bad it's 60

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 8, 2024

My bad it's 60

Ah thanks .... the runner does it on its own .... no wonder I wasn't able to find it in embedded-test itself 😆

@bugadani
Copy link
Contributor

bugadani commented Nov 8, 2024

PR pending: probe-rs/embedded-test#44

@JurajSadel
Copy link
Contributor Author

PR pending: probe-rs/embedded-test#44

Thank you! I will mark this as a draft and when it gets merged, I can update our HIL.

@MabezDev
Copy link
Member

MabezDev commented Nov 8, 2024

Thank you! I will mark this as a draft and when it gets merged, I can update our HIL.

You can use Daniel's branch with git and rev in hil-test for now

@jessebraham jessebraham marked this pull request as draft November 13, 2024 09:22
@JurajSadel JurajSadel marked this pull request as ready for review December 4, 2024 09:51
@JurajSadel JurajSadel changed the title HIL(QOL): Add missing timeouts to various tests HIL(QOL): Use global timeout instead of timeout macros Dec 4, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested it locally too.

@JurajSadel JurajSadel added this pull request to the merge queue Dec 4, 2024
Merged via the queue into esp-rs:main with commit d54f844 Dec 4, 2024
28 checks passed
@JurajSadel JurajSadel deleted the hil/timeouts branch December 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants