Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2c: attempt empty writes #2506

Merged
merged 6 commits into from
Nov 13, 2024
Merged

I2c: attempt empty writes #2506

merged 6 commits into from
Nov 13, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 8, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Closes #2504

@bugadani bugadani marked this pull request as ready for review November 12, 2024 11:08
hil-test/tests/i2c.rs Outdated Show resolved Hide resolved
@bugadani bugadani enabled auto-merge November 13, 2024 09:43
@bugadani bugadani added this pull request to the merge queue Nov 13, 2024
Merged via the queue into esp-rs:main with commit 8cbc249 Nov 13, 2024
28 checks passed
@bugadani bugadani deleted the i2c-empty branch November 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2C doesn't error correctly on empty transfers
3 participants