-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pins from Io
#2508
Remove pins from Io
#2508
Conversation
7234bbc
to
61ac0d2
Compare
8319f71
to
bf59f7a
Compare
0cf07f8
to
ec8583e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This caught my eye but I don't think it's important enough to change.
peripherals: [
// comma separated
],
pins: [
// not comma separated
]
(Mildly surprised the S2's GPIO alternative functions haven't been mapped out yet)
I didn't want to mess with the macro syntax, this is a straight-up cut and paste. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - lots of changes but a lot of that is unavoidable noise
This PR has two implications:
Io
Io
so users could no longer call methods on it.This is a slight variation on the idea originally raised by #2010 (comment)
Sorry, this touches literally every example we have.