[DMA 2/N] Split DMA IN/OUT handlers #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
changed the title
Dominaezzz
reviewed
Nov 13, 2024
Dominaezzz
reviewed
Nov 13, 2024
jessebraham
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses separate interrupts where available (C6, H2, S3), and adds a global flag where there is a single handler for the two DMA halves. This means that if a DMA channel's halves are configured differently, only the async halfs bits are cleared.
This is currently a bit of a half measure (we don't handle blocking-async mixtures yet), but it is impossible to register a user handler for a half DMA channel currently. In the future, in case the user registers a custom handler, we can swap out the handler function to one that supports two separate callbacks.