-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out PHY initialization. #2534
base: main
Are you sure you want to change the base?
Conversation
af91637
to
c4379c1
Compare
So far, I have only partially implemented shared radio clock control. I haven't updated esp-wifi yet, since I wasn't sure if this design is ok for everyone, so feedback is welcome. |
d0625dd
to
c346e73
Compare
Besides a couple of stylistic nitpicks I'll not list, I think the direction here is all right, although I don't see how upcoming work may change things around this. |
Ok! Glad to hear that. The reason I made the PHY status static is, because next I want to implement splitting the control over the radio clocks for the individual modems, and the PHY still needs to be controlled centrally. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR aims to provide a unified way of initializing the PHY. So far, only radio clock handling has been overhauled.
Testing