Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct toolchain when building documentation or running doctests via xtask #2536

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jessebraham
Copy link
Member

No description provided.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Nov 14, 2024
@@ -35,13 +36,15 @@ enum Cli {
/// Bump the version of the specified package(s).
BumpVersion(BumpVersionArgs),
/// Format all packages in the workspace with rustfmt
#[clap(alias = "format-packages")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have cargo xfmt if you want to save a few keystrokes :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more just habit than anything at this point 😁 Thanks for pointing that out, though.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will save my sanity I'm pretty sure

@jessebraham jessebraham added this pull request to the merge queue Nov 14, 2024
Merged via the queue into esp-rs:main with commit 014a04f Nov 14, 2024
29 checks passed
@jessebraham jessebraham deleted the feature/xtask branch November 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants