Add a publish subcommand to the xtask (which performs a dry-run by default)
#2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Considered adding a |
jessebraham
force-pushed
the
feature/xtask
branch
from
c641d47 to
006e747
Compare
jessebraham
changed the title
dry-run subcommand to xtask to run cargo publish --dry-run with required argumentspublish subcommand to the xtask (which performs a dry-run by default)
|
Okay I ended up changing it to |
jessebraham
force-pushed
the
feature/xtask
branch
from
006e747 to
5daa43d
Compare
MabezDev
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
LGTM, thanks!
Okay I ended up changing it to publish, which performs a dry-run by default but can optionally be supplied --no-dry-run
I think this is the most sane option, it should avoid most issues - worst case we can always yank the release if we mess up somewhere.
SergioGasquez
approved these changes
Nov 14, 2024
Co-authored-by: Sergio Gasquez Arcos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work as far as I can tell 😅