-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable documentation proof of concept #2628
Conversation
Looks good! How do we want to go about landing this? We could mark all the modules we're not actively trying to stabilize in this PR, and then for the modules we are trying to stabilize we add the analysis issue link to each? Alternatively we could leave the 4 drivers we're trying to stabilize alone in this PR and follow up with the outcome from the analysis issues. |
I guess the third option is don't mark anything yet, but just merge this as the prior construction work |
As this PR doesn't address #2499 I don't think I should mark anything unstable :) But:
|
I guess I should at least changelog the new feature, but maybe also start writing the migration guide as well. I don't think we need anything fancy, but this will need to be mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It will take some amount of work to label all such things, but PoC is successful IMO.
Closes #2498