Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prelude #2845

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Remove prelude #2845

merged 2 commits into from
Dec 20, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Dec 19, 2024

Closes #2660

skip-changelog because other crates were prelude users.

@bugadani bugadani force-pushed the prelude branch 4 times, most recently from 7689bb8 to 2b427a4 Compare December 19, 2024 14:30
@bugadani bugadani marked this pull request as ready for review December 19, 2024 21:17
@bugadani bugadani added the skip-changelog No changelog modification needed label Dec 19, 2024
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ added this pull request to the merge queue Dec 20, 2024
Merged via the queue into esp-rs:main with commit 7f8af8a Dec 20, 2024
28 of 39 checks passed
@bugadani bugadani deleted the prelude branch December 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the prelude
3 participants