Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/inline Pin::gpio_bank #2850

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove/inline Pin::gpio_bank #2850

merged 1 commit into from
Dec 20, 2024

Conversation

bugadani
Copy link
Contributor

The idea is that maybe a single enum dispatch optimizes better than two. It may help, or it may not, but the results means that Pin has one less hidden public private method.

@bugadani bugadani added the skip-changelog No changelog modification needed label Dec 20, 2024
bjoernQ
bjoernQ approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps the compiler in optimization needs to be checked but it won't make anything worse and good to see that function go

JurajSadel
JurajSadel approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Dec 20, 2024
Merged via the queue into esp-rs:main with commit d66e153 Dec 20, 2024
29 checks passed
@bugadani bugadani deleted the gpio branch December 20, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @JurajSadel