Mark SPI slave as unstable #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Dec 20, 2024
| @@ -216,7 +216,9 @@ macro_rules! unstable { | |||
| }; | |||
| } | |||
|
|
|||
| unstable! { | |||
| pub(crate) use unstable_module; | |||
There was a problem hiding this comment.
I had to rename the macro, otherwise I couldn't re-export it.
bjoernQ
reviewed
Dec 20, 2024
| @@ -91,16 +93,17 @@ const MAX_DMA_SIZE: usize = 32768 - 32; | |||
| /// SPI peripheral driver. | |||
| /// | |||
| /// See the [module-level documentation][self] for more details. | |||
| #[instability::unstable] | |||
There was a problem hiding this comment.
given the whole module is unstable this is just to make the docs look nicer, right? (just in case I am missing something important here)
There was a problem hiding this comment.
That, and we'll have to explicitly go through these once we commit to stabilizing SPI slave. FWIW rustdoc tends to ignore these, too, in places.
JurajSadel
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.