GPIO: Refactor AnyPin to contain a u8
#2854
Open
+118
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
gpio-opt
branch
2 times, most recently
from
009ddbb to
5e80ef0
Compare
bugadani
changed the title
Flex::set_levelu8
bjoernQ
reviewed
Dec 20, 2024
| @@ -3231,7 +3231,7 @@ impl Driver { | |||
| // wait | |||
| } | |||
| } else if #[cfg(esp32)] { | |||
| xtensa_lx::timer::delay(1); | |||
| xtensa_lx::timer::delay(2); // ☠️ | |||
There was a problem hiding this comment.
any idea why we need this now?
|
I can reproduce the 1.60 MHz for the erased case 🚀 |
The slight problem with that is, that we're not actually testing the performance of the erased GPIO, but the compilers ability to const-propagate the pin number. We need a better benchmark going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the compiler is WAY better at propagating a single
u8than an enum of different types. My silly little benchmark is now completely const-propagated and toggles at 1.6MHz.As a neat bonus, we can now provide
AnyPin::steal