Make ConfigError enum follow naming convention
#2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
reviewed
Dec 20, 2024
esp-hal/CHANGELOG.md
Outdated
| @@ -94,6 +94,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - User-bound GPIO interrupt handlers should no longer interfere with async pins. (#2625) | |||
| - `spi::master::Spi::{into_async, into_blocking}` are now correctly available on the typed driver, to. (#2674) | |||
| - It is no longer possible to safely conjure `GpioPin` instances (#2688) | |||
| - Make ConfigError enum follow naming convention (#2855) | |||
There was a problem hiding this comment.
it's a bit generic given there is just one renamed enum variant
There was a problem hiding this comment.
Can we avoid double-changelogging stuff? We just added this variant, why are we also documenting that is also changed? We could just stop writing the changelog at all and point people at the git history at this rate...
bjoernQ
approved these changes
Dec 20, 2024
jessebraham
approved these changes
Dec 20, 2024
playfulFence
force-pushed
the
upd/wtbeta
branch
from
c8727b5 to
ecce8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2831 (comment)