Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Info,State,Instance #2856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Hide Info,State,Instance #2856

wants to merge 1 commit into from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 20, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Closes #2766 but not fully #2697 (besides hiding AlternateFunction - posted an open question there)

Additionally it marks gpio/etm, gpio/lp_io, gpio/rtc_io, gpio/etm, RtcPin, RtcFunction, WakeEvent, RtcPinWithResistors , AnalogPin, TouchPin as unstable.

TouchPin is feature gated by #[cfg(touch)]

No CHANGELOG.md entry (can add it if we want it - seems unnecessary since one of the main things to mention for the next release is the introduction of the unstable feature)

Testing

n.a. / builds passing

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Dec 20, 2024
@bjoernQ bjoernQ marked this pull request as draft December 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private details should not leak into the public API
2 participants