Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using nb::Result as a return type #2882

Merged
merged 32 commits into from
Jan 17, 2025

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jan 3, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This PR modifies spi/uart/timer to remove some nb::Results and embedded-hal-nb stuff.

Testing

Describe how you tested your changes.

Closes #2729
Closes #2730

@SergioGasquez SergioGasquez force-pushed the feat/remove-nb branch 2 times, most recently from c0e99a3 to 34ea519 Compare January 3, 2025 14:15
esp-hal/Cargo.toml Outdated Show resolved Hide resolved
@SergioGasquez SergioGasquez force-pushed the feat/remove-nb branch 3 times, most recently from 6cf562b to 8bf7839 Compare January 3, 2025 15:26
esp-hal/src/hmac.rs Outdated Show resolved Hide resolved
esp-hal/src/uart.rs Outdated Show resolved Hide resolved
esp-hal/src/uart.rs Outdated Show resolved Hide resolved
esp-hal/src/uart.rs Outdated Show resolved Hide resolved
esp-hal/src/timer/mod.rs Outdated Show resolved Hide resolved
@SergioGasquez SergioGasquez force-pushed the feat/remove-nb branch 4 times, most recently from 211fe06 to 4652d56 Compare January 9, 2025 11:20
@SergioGasquez SergioGasquez force-pushed the feat/remove-nb branch 2 times, most recently from 45d6e64 to 3425f33 Compare January 13, 2025 08:36
@bugadani
Copy link
Contributor

If we're not removing the nb package, should we at least gate it behind unstable?

@SergioGasquez SergioGasquez changed the title Remove nb crate Avoid using nb::Result as a retrurn type Jan 13, 2025
@SergioGasquez
Copy link
Member Author

If we're not removing the nb package, should we at least gate it behind unstable?

I just removed embedded-hal-nb, the only non-stable driver that was using it was usb_serial_jtag, if anyone has any concerns and prefer to have the traits for it behind the unstable just let me know

@SergioGasquez
Copy link
Member Author

I guess it would be good to resolve #2935 before merging this PR.

@bugadani
Copy link
Contributor

I guess it would be good to resolve #2935 before merging this PR.

No need, I don't mind rebasing that, and you came here first :)

@SergioGasquez SergioGasquez force-pushed the feat/remove-nb branch 4 times, most recently from b5e2a3b to 90d2225 Compare January 13, 2025 14:11
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MabezDev MabezDev added this pull request to the merge queue Jan 17, 2025
Merged via the queue into esp-rs:main with commit c88dbef Jan 17, 2025
28 checks passed
@SergioGasquez SergioGasquez deleted the feat/remove-nb branch January 17, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants