-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using nb::Result as a return type #2882
Conversation
c0e99a3
to
34ea519
Compare
6cf562b
to
8bf7839
Compare
8bf7839
to
149e7ac
Compare
211fe06
to
4652d56
Compare
45d6e64
to
3425f33
Compare
If we're not removing the nb package, should we at least gate it behind |
I just removed |
I guess it would be good to resolve #2935 before merging this PR. |
No need, I don't mind rebasing that, and you came here first :) |
b5e2a3b
to
90d2225
Compare
Co-authored-by: Dániel Buga <[email protected]>
d61917f
to
a52a369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR modifies spi/uart/timer to remove some nb::Results and embedded-hal-nb stuff.
read_byte
/write_byte
are now blocking for uart and spi.read_bytes
/write_bytes
return how many bytes they read/wrote.Testing
Describe how you tested your changes.
Closes #2729
Closes #2730