Remove Pin trait impls from Flex #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
flex-rtc
branch
2 times, most recently
from
170eb80 to
3b9f222
Compare
bugadani
changed the title
bugadani
force-pushed
the
flex-rtc
branch
2 times, most recently
from
d566f05 to
a625262
Compare
MabezDev
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sleep APIs are unstable and these traits are also marked as "unfortunate implementation details" (by me...) so I think it's best if we rip them out and revisit later.
As for
Pin, the trait isn't actually needed by the interconnect impl.