Switch wifi tasks at priority level 3 #3165
Open
+27
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsurprisingly I see slightly worse performance running wifi_embassy_bench but this might benefit from possible future enhancements of the scheduler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3164 because ESP32 uses Software0 for some bluetooth-related things. Closes #3160 although not by switching tasks at level 1, but at level 3. The scheduler tick is ticking at level 1, though, so the scheduler is technically running at priority level 1, allowing us to use prio-limited locks at level 1 safely, unless someone calls
yield_taskin such a lock.The downside of this PR is that the timer interrupt is now triggering a software interrupt to switch tasks, which is probably slightly less performant than before.