Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix us waits in embassy hanging #906

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Fix us waits in embassy hanging #906

merged 5 commits into from
Nov 7, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 7, 2023

The check removed in #737 seems to break waits in the order of a few microseconds. In these cases, the interrupt handler does not fire even though the TRM seems to indicate it should. This PR restores the check and makes a few additional simplifications.

TIMG0 driver seems unaffected.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@bugadani bugadani changed the title Embassy time driver simplifications Fix us waits in embassy hanging Nov 7, 2023
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@MabezDev MabezDev merged commit 780a7f5 into esp-rs:main Nov 7, 2023
17 checks passed
@bugadani bugadani deleted the alarm branch November 7, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants