Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H2: prepare modem clocks for BLE #953

Merged
merged 2 commits into from
Nov 17, 2023
Merged

H2: prepare modem clocks for BLE #953

merged 2 commits into from
Nov 17, 2023

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Nov 17, 2023 •
edited
Loading

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Reuse ieee802154_clock_enable/disable() functions for BLE and rename ble_ieee802154_clock_enable()

bjoernQ
bjoernQ approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@MabezDev MabezDev added this pull request to the merge queue Nov 17, 2023
Merged via the queue into esp-rs:main with commit 4d87e75 Nov 17, 2023
17 checks passed
@JurajSadel JurajSadel deleted the feature/h2-modem-enable branch November 20, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JurajSadel @bjoernQ @MabezDev