Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to see what it looks like when RMT traits don't have CHANNEL as a generic parameter.
It seems to work, and I think the API is simpler. The one disadvantage is that we can no longer have a type that impls both, say,
TxChannel<0>
andTxChannel<1>
.Must
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have