Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rmt channels 2 #959

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Rmt channels 2 #959

merged 2 commits into from
Jan 30, 2024

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Nov 18, 2023

This is a draft to see what it looks like when RMT traits don't have CHANNEL as a generic parameter.

It seems to work, and I think the API is simpler. The one disadvantage is that we can no longer have a type that impls both, say, TxChannel<0> and TxChannel<1>.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@jessebraham
Copy link
Member

Sorry for letting this linger for so long. I don't have any strong opinions either way, this looks fine to me. @bjoernQ and @MabezDev can weigh in if they'd like.

If you'd still like to pursue this, would you be able to rebase this and get it to a mergeable state please? Otherwise we can close this for the time being.

@jneem
Copy link
Contributor Author

jneem commented Jan 30, 2024

Thanks for the reminder, I'd forgotten about this! I don't have a strong opinion either, but I do think it's a reasonable simplification so here's a rebased PR

@jneem jneem marked this pull request as ready for review January 30, 2024 15:24
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! This also dropped off my radar, but looks like a nice change. Thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Jan 30, 2024
Merged via the queue into esp-rs:main with commit 6f73815 Jan 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants