Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining device-specific linker scripts into esp-hal-common #963

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jessebraham
Copy link
Member

With the direct-boot and mcu-boot features removed, I've decided to consolidate these linker scripts into esp-hal-common, continuing to slowly advance toward the possibility of making #446 a reality.

No changes to the linker scripts themselves were made, with the exception of linkall.x which just updated the names of some files I had renamed.

This is at least passing CI, haven't tested with esp-wifi yet but I assume everything should be happy there.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Nov 20, 2023
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham added this pull request to the merge queue Nov 20, 2023
Merged via the queue into esp-rs:main with commit 04f63b7 Nov 20, 2023
17 of 18 checks passed
@jessebraham jessebraham deleted the fixes/consolidate branch November 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants