[nits] Convert request_content_len to i32 because it would be casted to i32 finally #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make type of
request_content_len
property inEspHttpConnection
struct fromu64
toi32
.Why
Now I'm working on #310 . I noticed the second argument of
esp_http_client_open
method expectsi32
value, notu64
. Butrequest_content_len
type isu64
. I investigatedrequset_content_len
property but it seems there is no reason thatrequest_content_len
type should beu64
. So I want to modify it toi32
because it would make more easier to implement #310 .When I remove
as _
from https://github.com/esp-rs/esp-idf-svc/blob/master/src/http/client.rs#L251 , then shows the error as below.How
Replace
u64
type withi32
ofrequest_content_len
property. Then removeas _
syntax for them because now it has expected type.