Derive listen_interval from ClientConfiguration #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClientConfiguration struct from embedded-svc has been updated to include the `listen_interval` field. This updates the `wifi_sta_config_t` construction to use the new `listen_interval` from ClientConfiguration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClientConfiguration struct from embedded-svc has been updated to include the
listen_intervalfield.This updates the
wifi_sta_config_tconstruction to use the newlisten_intervalfrom ClientConfiguration.Depends on esp-rs/embedded-svc#81
I'm not really sure what the process here is for submitting PR's that depend on upstream package changes. Do I need to do anything other than land the upstream PR?