Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe wrappers for wifi promiscuous #536

Merged
merged 5 commits into from
Jan 1, 2025
Merged

Conversation

indexds
Copy link
Contributor

@indexds indexds commented Dec 27, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

Second part of #246, adds wrappers for esp_wifi_get_promiscuous and esp_wifi_set_promiscuous.

If I find the time I'll make wrappers for those three functions in the todo, though for now this fixes #246.

Testing

Minimal repo, it works.

@indexds indexds changed the title Wifi promiscuous Safe wrappers for wifi promiscuous Dec 27, 2024
Copy link
Collaborator

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

src/wifi.rs Outdated Show resolved Hide resolved
@indexds
Copy link
Contributor Author

indexds commented Dec 27, 2024

ps: you might want to add something like this to your workflows:

on:
push:
paths-ignore:
- README.md
- ...

@ivmarkov ivmarkov merged commit 1c5d574 into esp-rs:master Jan 1, 2025
15 checks passed
@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 1, 2025

Thanks!

@indexds indexds deleted the wifi_promiscuous branch January 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing wraper for promiscous mode.
2 participants