💬 add all in one option #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vollbrecht
commented
Feb 6, 2024
Vollbrecht
commented
- address feedback of 💬 use espflash 2 api in command #183 -
- add hint for backtrace decode usage
ivmarkov
reviewed
Feb 6, 2024
| @@ -122,6 +130,12 @@ I (272) cpu_start: Starting scheduler on PRO CPU. | |||
| I (0) cpu_start: Starting scheduler on APP CPU. | |||
| Hello, world! | |||
| ``` | |||
| ##### Backtrace | |||
There was a problem hiding this comment.
If we open the topic of backtrace decoding, shouldn't we mention that decoding for riscv chips is incorrect or maybe even wrong by using this approach? And point the reader to the EH frame setup?
There was a problem hiding this comment.
i could add a footnote, and add a little section on what to add to the bottom?
There was a problem hiding this comment.
Anything would work as long as it is clear for the users that what is suggested in this paragraph won't work well on anything but xtensa...
There was a problem hiding this comment.
Or else we would be opening even more statements of "it does not work as per the documentation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.