Update dependencies, port to portable-atomic #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
atomic
branch
12 times, most recently
from
5b06b4f to
a1c617f
Compare
bugadani
commented
Nov 14, 2023
bugadani
force-pushed
the
atomic
branch
9 times, most recently
from
58ffbae to
5da7d30
Compare
bugadani
changed the title
Merged
bjoernQ
approved these changes
Nov 28, 2023
|
I think I'd like to hear @MabezDev's opinion as this is intended to be part of the atomic emulation related changes. |
bugadani
force-pushed
the
atomic
branch
8 times, most recently
from
cadd6a4 to
4184579
Compare
MabezDev
requested changes
Dec 4, 2023
MabezDev
reviewed
Dec 4, 2023
bugadani
force-pushed
the
atomic
branch
2 times, most recently
from
884a4c9 to
3bea633
Compare
bugadani
changed the title
|
I went the lazy route and enabled portable-atomic on all targets. I can undo it if I shouldn't but I'm not sure right now. |
MabezDev
approved these changes
Dec 4, 2023
|
I ran my tests and everything looks good. For C6 it needs the fix in esp-rs/esp-hal#997 however |
|
Update esp-hal to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on the next esp-hal release. The PR keeps atomic emulation stuff enabled for ESP32-S2 because the old heapless doesn't know about xtensa and so it won't enable atomic-polyfill even with the
casfeature enabled. Other than that, RISC-V targets should now be able to compile esp-wifi with the emulation trap disabled.Closes #337
Closes #373