Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recommendation against LTO #363

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Remove recommendation against LTO #363

merged 1 commit into from
Nov 28, 2023

Conversation

bugadani
Copy link
Contributor

Closes #341

MabezDev
MabezDev approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the Xtensa backend got a lot better since we recommended turning it off.

bjoernQ
bjoernQ approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 858a9a3 into esp-rs:main Nov 28, 2023
7 checks passed
@bugadani bugadani deleted the lto branch November 28, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status of LTO
3 participants
@bugadani @bjoernQ @MabezDev